search

DERHAEUPTLING / contao-immobilienscout24-import-bundle

ImmobilienScout24 Import Plugin for Contao
GNU General Public License v3.0
1 stars 2 forks source link

Error with RegistryInterface on doctrine/doctrine-bundle 2.* #31

Closed OMOSde closed 3 years ago

OMOSde commented 3 years ago

I installed the bundle in a Contao 4.9.20 (Symfony 4.4.30).

Afterwards there were error messages concerning the class RegistryInterface when creating an account.

The cause is probably a remove of a deprecation in doctrine/doctrine-bundle 2.0 (see: https://github.com/doctrine/DoctrineBundle/blob/2.3.x/UPGRADE-2.0.md).

I then made adjustments in my installation following this example (https://github.com/sonata-project/SonataPageBundle/pull/1099/files) and all problems were solved.

Best regards René

m-vo commented 3 years ago

The cause is probably a remove of a deprecation in doctrine/doctrine-bundle 2.0 (see: https://github.com/doctrine/DoctrineBundle/blob/2.3.x/UPGRADE-2.0.md).

Thanks for debugging. I think we can safely exchange the interface here, too. We should probably also add doctrine/doctrine-bundle to our requirements (with ^1.8 || ^2.0).

Could you provide a PR with the needed fixes?

Metis77 commented 3 years ago

@OMOSde So great you could solve this one. Would you like to offer a pull request with the fixes?

OMOSde commented 3 years ago

I think this is my first pull request. I hope I did everything right.

m-vo commented 3 years ago

Closing in favor of #32