search

DESI-UR / VAST

Void Analysis Software Toolkit
https://vast.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

Periodic #70

Closed QuiteAFoxtrot closed 2 years ago

QuiteAFoxtrot commented 2 years ago

Enabled periodic evaluation of a provided survey with a rectangular set of xyz_limits who is specially constructed such that each of the 3 dimensions share a common integer divisor. Use mask_type="periodic" for the new mode

Includes a handful of Cython updates, a bit of parameter consolidation/simplification for the main find_voids() api.

Incremented minor version number (1.1.1 -> 1.2.1 actually 1.2.0 fixed in a further commit) due to size of the update and slight breaking of the main find_voids() interface due to parameter consolidation.

QuiteAFoxtrot commented 2 years ago

I think this update may have also sped up VoidFinder by a minor amount (5-10%, but seeing times on DR7 of 4.5 sec where I used to see like 5+ seconds). I think largely due to now full usage of cython typing in the core functions