In the unit test for VoidFinder, found a test case where a hole was being found which had numerous wall galaxies significantly inside it. It dissapears/reappears with a comment out for a final-extra-check in find_next_galaxy() possibly indicating a logic error somewhere. Possibly related to main_algorithm() checking potential bad unit vectors when finding the 4th bounding galaxy.
kadglass
commented
1 year ago
In the unit test for VoidFinder, found a test case where a hole was being found which had numerous wall galaxies significantly inside it. It dissapears/reappears with a comment out for a final-extra-check in find_next_galaxy() possibly indicating a logic error somewhere. Possibly related to main_algorithm() checking potential bad unit vectors when finding the 4th bounding galaxy.