search

DESI-UR / VAST

Void Analysis Software Toolkit
https://vast.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

Internals rewrite #94

Closed QuiteAFoxtrot closed 1 year ago

QuiteAFoxtrot commented 1 year ago

Big rewrite of the VF internals, eliminated the "dr" parameter completely. Now the hole growing is done by starting from the previous sphere center, and just checking local neighborhood galaxies, and if nothing is found, increment to another "shell" of cubes surrounding the current location and check all those galaxies. Previously this was done by iterating along the search vector by some amount 'dr', doing a radius query, and checking all those galaxies. This new method eliminates the unknown number of 'dr' iterations and replaces it with direct use of the search grid instead.

Also cleaned up a number of comments and such.

This makes issue #13 irrelevant. This rewrite also took care of probably 90% of issue #45 though I don't think we should close that just yet.

Overall, these improvements speed up the hole-growing portion of VoidFinder by approximately 1.5x on SDSS DR7.

QuiteAFoxtrot commented 1 year ago

THis will now close #92 since v2misc was merged in here