search

DEVSENSE / Phalanger

PHP 5.4 compiler for .NET/Mono frameworks. Predecessor to the opensource PeachPie project (www.peachpie.io).
http://v4.php-compiler.net/
Apache License 2.0
381 stars 92 forks source link

Remove "import" keyword #50

Open robertleeplummerjr opened 9 years ago

jakubmisek commented 9 years ago

We can't remove "import" in this way since it is Phalanger keyword, needed by older apps. The proper way would be to handle it in Scanner.cs, reinterpret T_IMPORT in case you don't want it (currently "import" is only interpreted as keyword if you are compiling in Pure mode)

robertleeplummerjr commented 9 years ago

I figured it would be rejected. Loud and clear, let me see what I can roll out in the next few minutes...

On Tue, Apr 7, 2015 at 12:36 PM, Jakub Míšek notifications@github.com wrote:

We can't remove "import" in this way since it is Phalanger keyword, needed by older apps. The proper way would be to handle it in Scanner.cs, reinterpret T_IMPORT in case you don't want it (currently "import" is only interpreted as keyword if you are compiling in Pure mode)

— Reply to this email directly or view it on GitHub https://github.com/DEVSENSE/Phalanger/pull/50#issuecomment-90639741.

Robert Plummer

robertleeplummerjr commented 9 years ago

How about them apples?

robertleeplummerjr commented 9 years ago

Does this implementation work for you?