Wrong string-class template detection

[Morgy93]

Hello,

I have a method like:

    /**
     * Returns view model instance for given FQN
     *
     * @template T
     * @param string-class<T> $viewModelClass Fully qualified class name (FQN)
     * @param AbstractBlock|null $block Only required if view model is used within a template cached in ESI (ttl="n" in layout XML)
     * @return T
     * @throw InvalidViewModelClass if class not found or not a view model
     */
    public function require(string $viewModelClass, AbstractBlock $block = null): ArgumentInterface

Using it throws an PHP0406 | Argument type mismatch error:

$class->require(\Some\Class:class)

Argument '1' passed to require() is expected to be of type Class\With\Require\string-class, string given

Any idea what's wrong here?

[jakubmisek]

Thank you for the question.

I think the standard name is class-string (not string-class) https://phpstan.org/writing-php-code/phpdoc-types#class-string

We can support both if it's used by some other code sniffer.

[Morgy93]

Interesting, that code is provided by a third party.

But it seems that it should be class-string indeed.

I'll open a PR on that code. If there is any reason, they need it like this, I'll update this issue.

Thank you 🙌

[jakubmisek]

Thank you @Morgy93 - please let us know if there will be anything we can do.