One-line conditional echo statement causes incorrect syntax highlighting and formatting in VSCode

[alexanderroidl]

The following PHP code...

<?php for ($p = $pages; $p > 0; $p--): ?>
    <li<?= ($gb_page == $p) ? ' class="active"' : ''; ?>>
        <a href="index.php?page=gb&gbpage=<?= $p; ?>"><?= $p; ?></a>
    </li>
<?php endfor; ?>

...is getting formatted like this...

<?php for ($p = $pages; $p > 0; $p--): ?>
    <li<?= ($gb_page == $p) ? ' class="active"' : ''; ?>>
        <a href="index.php?page=gb&gbpage=<?= $p; ?>"><?= $p; ?></a>
        </li>
    <?php endfor; ?>

...while also being highlighted like this (see line 2):

System info

OS: Ubuntu 24.04 LTS
PHP version: 8.3.6
Visual Studio Code version: 1.90.0 89de5a8d4d6205e5b11647eb6a74844ca23d2573 x64
phptools-vscode version: 1.47.15512

[jakubmisek]

Thank you for reporting the issues.

• [ ] The colors are caused by a bug in VSCode :/ We'll try to find a workaround. To speed things up, you may create an issue at https://github.com/microsoft/vscode/issues
• [ ] formatting is probably an issue in our extension - we'll take a look at that - (cc @Miloslav)

[Miloslav]

Quick hotfix for both issues would be to change the code, so there is a space after <li :

<?php for ($p = $pages; $p > 0; $p--): ?>
    <li <?= ($gb_page == $p) ? 'class="active"' : ''; ?>>
        <a href="index.php?page=gb&gbpage=<?= $p; ?>"><?= $p; ?></a>
    </li>
<?php endfor; ?>

Anyway, we will try to handle it on our end too.

Thanks

[alexanderroidl]

Thanks to both of you @Miloslav and @jakubmisek. I will post an issue in the VSCode repository sometime soon as well. Your work is much appreciated!