DEViantUA / StarRailCard

Module for generating Honkai Star Rail character cards
https://discord.gg/eu55vTgmSA
Other
42 stars 11 forks source link

Include all transitive dependencies when installing the module through PIP #8

Closed Iqrar99 closed 7 months ago

Iqrar99 commented 7 months ago

In an isolated env, when we run pip install starrailcard. It still didn't include all other necessary dependencies such as: aiohttp, numpy, more_itertools, cachetools, bs4, and such.

We were forced to pip them manually. It'll be good if you can include it on setup.py all required libs as well to make people more straightforward to use the module. Currently, only Pillow that is downloaded automatically.

DEViantUA commented 7 months ago

Module like base64 is a built-in module in Python. Its absence means that you installed Python by checking the box in the wrong place. In the new version I will add all additional modules but those that are standard will not be included

Iqrar99 commented 7 months ago

Well, thank you, but I was referring to bs4 as beautifulsoup4