search

DEVmachine-fr / cert-manager-alidns-webhook

Cert-manager webhook to generate Let's Encrypt certificates over Alibaba Cloud DNS.
Apache License 2.0
98 stars 31 forks source link

feat(chart): add securePort option #8

Closed m-yosefpor closed 3 years ago

m-yosefpor commented 3 years ago

Currently the webhook container is running on port 443. However in environments with extra security policies (such as Openshift), it's not possible to run a container on ports lower than 1024 (unless providing additional security constraints which requires admin privileges). So there should be an option to specify the container port (in our case to some number higher than 1024).

This PR does not change any behavior and is fully backward-compatible.

Tested on Openshift 4.7.

olivierboudet commented 3 years ago

Thanks, can you just update the chart version please ?

m-yosefpor commented 3 years ago

@olivierboudet done.