search

DEVmachine-fr / cert-manager-alidns-webhook

Cert-manager webhook to generate Let's Encrypt certificates over Alibaba Cloud DNS.
Apache License 2.0
98 stars 31 forks source link

feat: add support for additional env vars #9

Closed m-yosefpor closed 3 years ago

m-yosefpor commented 3 years ago

There are many use-cases to set additional env vars, e.g.

  1. for setting HTTP_PROXY, as in environments with restricted networks, pods might need to have a proxy to be able to access the internet (or for any other reason which they want to set proxy)

  2. for setting GOMAXPROCS as pods with low resources on large k8s nodes, get GOMAXPROCS == number of cores on nodes which causes cpu throttling issues. Users can manually set this to a lower value (e.g. number of cores in cpu.request)

In our use-case we need to set both, I think it is great if anyone can add this extra vars for their use-case instead of hard-coding it (it's also a common good practice in many official helm charts to allow customization)

This is fully backward compatible and doesn't change anything on existing deployments.

m-yosefpor commented 3 years ago

@olivierboudet Thanks for your prompt response. Suggestions applied.

olivierboudet commented 3 years ago

Thank you very much @m-yosefpor