Flask:2024-09-20#2

[iwmstjp]

After merging this PR, I will replace my repository to this repository on gpu-2. This will be my last PR.

Summary by Sourcery

Refactor the Flask application code for better readability and maintainability by renaming constants and modularizing file handling logic. Enhance the user interface by adding a JavaScript function to improve error message interaction.

Enhancements:

• Refactor variable names to use uppercase for constants, improving code readability and consistency.
• Modularize the code by extracting file reading and cleaning logic into separate functions, enhancing maintainability.
• Add a new JavaScript function to handle error message scrolling, improving user interaction with error messages.

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request refactors and improves the Flask application for MetagenoMongo. It focuses on code organization, error handling, and file import functionality. The changes aim to enhance code readability, maintainability, and robustness.

File-Level Changes

Change	Details	Files
Refactored global variables and constants	Renamed variables to use uppercase for constants Simplified the initialization of global variables	flask-version/metagenomongo/app.py
Improved file import functionality	Added new functions for cleaning and checking imported files Separated file reading logic into a dedicated function Enhanced error handling for file imports	flask-version/metagenomongo/app.py
Refactored and simplified route handlers	Removed redundant data preparation function Simplified data handling in save() function Reorganized form data handling	flask-version/metagenomongo/app.py
Enhanced error message display	Added row number to error messages for better identification Moved error message scroll functionality to a separate function	flask-version/metagenomongo/static/index_with_table.js flask-version/metagenomongo/templates/index_with_table.html
Minor code style improvements	Added spacing between functions for better readability Removed commented-out code	flask-version/metagenomongo/module/validation.py

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

[iwmstjp]

@gpetho I replaced my repository with this repository on gpu-2.

[gpetho]

@iwmstjp I have merged this pull request. As you have noticed, I cleaned up the code slightly. I replaced the nested conditionals by a single flat conditional with and logical operators. The two are semantically equivalent, but I think a conjunction in a complex condition is easier to read and understand than nesting a conditional.