DFE-Digital / get-teacher-training-adviser-service

DFE-Digital Get Teacher Training Adviser Service
MIT License
2 stars 3 forks source link

Prevent caching of JS/CSS assets in development #1256

Closed ethax-ross closed 1 year ago

ethax-ross commented 1 year ago

Trello card

Trello-4299

Context

By default Shakapacker generates applicaton.js/css without any digest. This causes the browser to serve the cached version of the asset even after the contents have changed.

Changes proposed in this pull request

Change webpack to always generate JS/CSS asset filenames with a digest.

Also update webpack overlay to only show errors as we have deprecation warnings in dependencies we can't do anything about.

Guidance to review

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-actions[bot] commented 1 year ago

Review app deployed to https://review-teacher-training-adviser-1256.london.cloudapps.digital