Add redirect from the home page to GiT

DFE-Digital / get-teacher-training-adviser-service

DFE-Digital Get Teacher Training Adviser Service

MIT License

2 stars 3 forks source link

Add redirect from the home page to GiT #1377

Closed plisovin closed 1 year ago

plisovin commented 1 year ago

Trello card

Trello-4793

Context

Add top level redirect FROM https://adviser-getintoteaching.education.gov.uk/ TO https://getintoteaching.education.gov.uk/teacher-training-adviser/sign_up/identity

Changes proposed in this pull request

Guidance to review

plisovin commented 1 year ago

@gemmadallmandfe is it ok to add querystring param in the redirect (tta-redirect)? This will allow to count number of redirects form TTA to GiT in kibana

gemmadallmandfe commented 1 year ago

@gemmadallmandfe is it ok to add querystring param in the redirect (tta-redirect)? This will allow to count number of redirects form TTA to GiT in kibana

I can't see why not - however, I'd suggest that we use a different query param if possible as this was used specifically for internal links previously - might make more sense to use something new eg ?adviser-redirect

Will need to test once the PR has rebuilt successfully though

gemmadallmandfe commented 1 year ago

@gemmadallmandfe is it ok to add querystring param in the redirect (tta-redirect)? This will allow to count number of redirects form TTA to GiT in kibana

I can't see why not - however, I'd suggest that we use a different query param if possible as this was used specifically for internal links previously - might make more sense to use something new eg ?adviser-redirect

Will need to test once the PR has rebuilt successfully though

@plisovin Is there any reason why we couldn't use utm parameters so it is easy to track in GA? eg https://getintoteaching.education.gov.uk/teacher-training-adviser/sign_up/identity?utm_source=adviser-getintoteaching.education.gov.uk&utm_medium=referral&utm_campaign=adviser_redirect

github-actions[bot] commented 1 year ago

Review app deployed to https://review-teacher-training-adviser-1377.london.cloudapps.digital

plisovin commented 1 year ago

@plisovin Is there any reason why we couldn't use utm parameters so it is easy to track in GA? eg https://getintoteaching.education.gov.uk/teacher-training-adviser/sign_up/identity?utm_source=adviser-getintoteaching.education.gov.uk&utm_medium=referral&utm_campaign=adviser_redirect

I will add

github-actions[bot] commented 1 year ago

Review app deployed to https://review-teacher-training-adviser-1377.london.cloudapps.digital