search

DFE-Digital / get-teacher-training-adviser-service

DFE-Digital Get Teacher Training Adviser Service
MIT License
2 stars 3 forks source link

Add all path redirect to GiT #1378

Closed plisovin closed 10 months ago

plisovin commented 10 months ago

Trello card

Trello-4793

Context

Add wildcard redirect FROM https://adviser-getintoteaching.education.gov.uk/ TO https://getintoteaching.education.gov.uk/teacher-training-adviser/sign_up/identity (once there are no people left in the middle of the funnel on the adviser site)

Changes proposed in this pull request

Guidance to review

github-actions[bot] commented 10 months ago

Review app deployed to https://review-teacher-training-adviser-1378.london.cloudapps.digital

github-actions[bot] commented 10 months ago

Review app deployed to https://review-teacher-training-adviser-1378.london.cloudapps.digital

gemmadallmandfe commented 10 months ago

@plisovin I've tested this as best I could, by adding page slugs to the review app link - seems to work fine and redirects to the start of the funnel on GIT

github-actions[bot] commented 10 months ago

Review app deployed to https://review-teacher-training-adviser-1378.london.cloudapps.digital

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

plisovin commented 10 months ago

@plisovin - Do you think route spec or a test for the redirect is a good idea here ? This is to safeguard against any regression.

Good point! Added a test in this commit

github-actions[bot] commented 10 months ago

Review app deployed to https://review-teacher-training-adviser-1378.london.cloudapps.digital