YAML secret

[saliceti]

What

Extracts a single secret value from a YAML file stored in Azure key vault

How to review

• Follow README
• See successful run: https://github.com/DFE-Digital/register-trainee-teachers/runs/3914822649?check_suite_focus=true

[sfawcett123]

How difficult would it be to provide a list of secrets ?

[saliceti]

How difficult would it be to provide a list of secrets ?

Ideally we would need to have variable outputs but I couldn't find how to do it with the composite action (see https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#outputs-for-composite-actions). The alternative is to encode as json in the action, then decode when you use it but it makes it less easy to use.

The login step is the slowest. I'm thinking to remove it so you can call this action multiple times quickly.

[saliceti]

@sfawcett123 I've removed the azure login step fron this action. It is more standard with the other Azure actions as the login step is always done separately. It also make the retrieval of secrets faster, about 2-3s for each. So it doesn't make much difference to use a list of secrets now. We can look at that in the future but that will be much more work.

[sfawcett123]

Testing the code on https://github.com/DFE-Digital/schools-experience/pull/2050

[sfawcett123]

Other than in the comments maybe you should put ; it all works on my deployment.

      -  uses: actions/checkout@v2

[saliceti]

Github action to extract secret from keyvault yaml