search

DFE-Digital / register-early-career-teachers

This application will replace the Manage training for early career teachers service in 2025.
5 stars 0 forks source link

Initial GIAS import #367

Closed ltello closed 1 month ago

ltello commented 1 month ago

This PR contains basic functionality to do the first import of schools and their links from the GIAS api.

peteryates commented 1 month ago

Also eastings and northings don't make much sense. If we want to do anything geographic we'll need to convert them to a proper datatype anyway. I think we should drop them for now.

ltello commented 1 month ago

Also eastings and northings don't make much sense. If we want to do anything geographic we'll need to convert them to a proper datatype anyway. I think we should drop them for now.

We agreed to leave them for now as it is but I can exclude them as well.

ltello commented 1 month ago

Looks good to me.

I'm not sure we need both type_code and type_name though, especially as it means we need to hold the mapping too. What happens with this other than eligibility checking?

Ah ok, so you just want to work either with codes or names and do not keep the mapping?.

ltello commented 1 month ago

All done!