DFE-Digital / register-early-career-teachers

This application will replace the Manage training for early career teachers service in 2025.
5 stars 0 forks source link

View list of ECTs added in your school #468

Open mason-emily opened 4 days ago

mason-emily commented 4 days ago

Description

This story delivers a placeholder page that will provide:

This page can initially be based on the design of the AB portal landing page, and will later be iterated following further design and testing.

User story

As a school user I need to view a list of ECTs in my school So that I can see which ECTs have already been added and add more ECTs as needed

Prototype, screenshots & content

Link to prototype

Example 'View ECTs' page:

Image

Content should be as per the screenshot above.

Acceptance criteria

Technical notes

We need to create a persona linked to a school to mimic being signed in (DfE Sign In to be built later).

Note, whilst this page can be based initially on the AB portal landing page, it is just a placeholder for now and should be built as basic as possible since the design may change significantly.

TobyRet commented 4 days ago

@tonyheadford @peteryates

Should E2E testing be set up as part of this ticket? Or is it too soon ...

peteryates commented 3 days ago

I don't think there's any harm in it but as everything's likely to change it can be light touch for now.

We already have ECTAtSchoolPeriod records in the seed data so there's something to test with.

I think it makes sense to add pagination to this page while you're implementing this as we'll have to at some point anyway. See the AB list for inspiration.

claire-hughez commented 2 days ago

Will raise the PR to get feedback from devs of what is going on underneath the hood.

gracecbrennan commented 1 day ago

This is going back to in progress following review

TobyRet commented 7 hours ago

@claire-hughez @mason-emily

Regarding the above acceptance criteria ...

Criteria 1 - I've currently hardcoded the school id - this means, no matter what persona you log in as you will see the same ECTs and Mentors for that school. Apologies an over site on my part. Let me know if this is acceptable or if you prefer the school linked to the persona as originally intended

Criteria 4 - The ECT and Mentor data is not dummy data, rather seed data. Ie calls are being made to the database to retrieve data. This was suggested by Pete.

Criteria 5 - Although ECTs and mentors are listed, the links are not currently active - I would have thought that viewing individual ECTs and Mentors would be out of scope for this ticket? If you like I can pick this up next ...