search

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.
https://dfe-digital.github.io/schools-experience/
MIT License
9 stars 4 forks source link

Dependabot sidekiq 6.5.12 update with nokogiri fix #3014

Closed StackedPancakez closed 9 months ago

StackedPancakez commented 9 months ago

Trello card

5278

Context

The Docker build fails because it does not contain the platform specific installation of the nokogiri gem. Changes through bundler were failing to work, so explicitly adding.

Changes proposed in this pull request

Explicitly add the required platform specific version of nokogiri to the image.

Guidance to review

github-actions[bot] commented 9 months ago

Review app deployed to https://get-school-experience-review-pr-3014.test.teacherservices.cloud :white_check_mark: DfE AKS sign in route obtained: https://get-school-experience-review-pr-3.test.teacherservices.cloud

tejasjinaraldfe commented 9 months ago

I've tested both as both users (Candidate and School). All the steps, pages, and features are working as expected including email triggers.