search

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.
https://dfe-digital.github.io/schools-experience/
MIT License
9 stars 4 forks source link

testing get_next_mapping_aks.sh #3016

Closed temitope777 closed 9 months ago

temitope777 commented 9 months ago

Trello card

https://trello.com/c/nzPVjeyQ/796-fix-school-experience-review-app-url

Context

the dfe signin link was not working due to issues with the bash script that creates the link

Changes proposed in this pull request

fix the bash script and also ensure that terraform returns the link properly

Guidance to review

test dfe link eg https://get-school-experience-review-pr-3.test.teacherservices.cloud/schools/change

MylesJarvis commented 9 months ago

Tested - I can sign into DfE Sign In and act as a school. Therefore think this is all working as intended.

github-actions[bot] commented 9 months ago

Review app deployed to https://get-school-experience-review-pr-3016.test.teacherservices.cloud :white_check_mark: DfE AKS sign in route obtained: https://get-school-experience-review-pr-3.test.teacherservices.cloud