DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.
https://dfe-digital.github.io/schools-experience/
MIT License
9 stars 4 forks source link

Invite Users to GSE #3080

Closed ekumachidi closed 4 months ago

ekumachidi commented 5 months ago

Trello card

#5535

Context

We want to Integrate the Identity only version of DfE Sign-in with Get School Experience Build pages to add users to a school. Allow school administrators to invite users to the school that they administer through 'School Dashboard'

Changes proposed in this pull request

MylesJarvis commented 4 months ago

I'm going to add comments as and when I find them from a review, hope that's okay!

https://get-school-experience-review-pr-8.test.teacherservices.cloud/schools/users/new

image image
MylesJarvis commented 4 months ago

When in the Manage users page the link to DFE Sign-In goes to production automatically, should this be environment specific? I ask this as we are pulling the users who have access from (below this paragraph in the image below) Pre-prod DfE Sign In, we should probably link to pre-prod by default. Doing this will allow me to test the functionality of removing a user in the DSI console and seeing it disappear from this page.

image
MylesJarvis commented 4 months ago

I also have a couple of issues with backlinks (not going back) and 404 errors when adding a user:

404 error gse

ekumachidi commented 4 months ago

I'm going to add comments as and when I find them from a review, hope that's okay!

https://get-school-experience-review-pr-8.test.teacherservices.cloud/schools/users/new

  • At this URL, which is when I've clicked add user from the Manage Users Page (https://get-school-experience-review-pr-8.test.teacherservices.cloud/schools/users)
  • We need to style the Title
  • We need to ensure that first_name renders as First name
  • We need to ensure that last_name renders as Last name
  • We need to ensure that the cancel link groups to align with the 'continue' button (see image below from the Gov uk design system)

image image

This was the original design but I'm happy to make changes as per your feedback image

github-actions[bot] commented 4 months ago

Review app deployed to https://get-school-experience-review-pr-3080.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-8.test.teacherservices.cloud

tejasjinaraldfe commented 4 months ago

Review app deployed to https://get-school-experience-review-pr-3080.test.teacherservices.cloud ✅ DfE sign in route obtained: https://get-school-experience-review-pr-8.test.teacherservices.cloud

@ekumachidi please find below the comments as discussed during testing

  1. Add user first step - Firstname & Lastname change to First name & Last name

  2. On /schools/users page - DfE Sign-in link should redirect users to /approvals/users on the respective environments

  3. On /schools/users page when a new user is invited -

a. If the user already has a DfE Sign-in account:

b. If the user does not have a DfE Sign-in account:

  1. When the user logs out, they do not get redirected back to the Manage School Experience and see the following error

Error invalid_request post_logout_redirect_uri not registered