Implement new crown logo on Get school experience

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Implement new crown logo on Get school experience #3081

Closed ekumachidi closed 4 months ago

ekumachidi commented 4 months ago

Trello card

https://trello.com/c/eATAKW7V/

Context

The crown logo used across GOV.UK sites is changing following the coronation of King Charles III

Changes proposed in this pull request

Upgrades our version of Frontend from 4.7.0 to 4.8.0
Update GOV.UK logo in application layout

Guidance to review

Before: Screenshot 1

After: Screenshot 2

martyn-w commented 4 months ago

Hi @ekumachidi, the code changes look fine, however there is a node version error. Try updating the base image in the Dockerfile from ruby:3.1.0-alpine3.15 to ruby:3.1.4-alpine3.18 (that's what Get into Teaching is using)

github-actions[bot] commented 4 months ago

Review app deployed to https://get-school-experience-review-pr-3081.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-2.test.teacherservices.cloud

gemmadallmandfe commented 4 months ago

Crown tested successfully in review app - thanks @ekumachidi!

Happy for this to be merged once it has had tech eyes on it from @martyn-w