Help links update - Githubissues

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Help links update #3130

Closed ekumachidi closed 2 months ago

ekumachidi commented 3 months ago

Based on this review feedback: https://github.com/DFE-Digital/schools-experience/pull/3102#issuecomment-2032081928

MylesJarvis commented 3 months ago

Adding some further comments related to the wider branch/Original PR, as requested, on this PR:

I missed an additional space after 'support'. I'll remove this here.

MylesJarvis commented 3 months ago

When a user has previously chosen a school from the selection page (/schools/change) and then heads back to the dashboard, we have varying size of font and links.

We should fix this by implementing the correct grouping of links and keeping the 'contact DfE Sign In support text' at the very bottom.

MylesJarvis commented 3 months ago

Unusual journey when I reject cookies mid way through the add user journey, it resets the flow. I don't think this should happen.

Accepting-cookies-mid-add-user-journey

cc @gemmadallmandfe I know we want to ship this, so let me know what you think about ignoring this edge case for now.

MylesJarvis commented 3 months ago

I also think we should re-word this help text:

We should align it to elsewhere on the site:

So I suggest we do the following:

and the link should go to the Contact us page, as in the footer - https://schoolexperience.education.gov.uk/schools/contact_us

MylesJarvis commented 3 months ago

Not one for this PR (as we modify it in Notify) but putting here for completeness. I also think we should modify this email to better reflect the process.

We took this wholesale from Publish, but their flow actually differs in that they don't automatically generate a DfE Sign In account creation email. They expect the user to create an account separately.

Instead we should make use of Apply, which sends the following:

MylesJarvis commented 3 months ago

@ekumachidi I've updated the contact us URLs here and I believe we can merge this into the wider PR.

github-actions[bot] commented 3 months ago

Review app deployed to https://get-school-experience-review-pr-3130.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-4.test.teacherservices.cloud