Remove all candidate facing links to dashboard and redirect from relevant URLs

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Remove all candidate facing links to dashboard and redirect from relevant URLs #3138

Closed MylesJarvis closed 5 months ago

MylesJarvis commented 5 months ago

Trello card

https://trello.com/c/ZwpPMswx / https://trello.com/c/hUqhlo9f

Context

This is a spike into how we might remove the candidate dashboard in a quick fashion.

This PR doesn't remove the functionality, but removes all links to it across the service. A user could still access the functionality through inputting the URL directly, but this will reduce usage significantly.

Changes proposed in this pull request

Remove the ability to access the dashboard through anchor links in the service.
Fix tests associated with clicking on these anchor links

Guidance to review

gemmadallmandfe commented 5 months ago

/candidates/signin is still accessible directly from the URL - think we need to add a redirect @MylesJarvis:

FROM /candidates/signin TO /

MylesJarvis commented 5 months ago

@ekumachidi is going to pick this up now I've done the basic implementation of removing external facing links. He's going to redirect away from the following URLs:

/candidates/signin -> /candidates
/candidates/dashboard* -> /candidates: this will need a wildcard as we have pagination on requests e.g. /candidates/dashboard?page=3

MylesJarvis commented 5 months ago

Tested this - redirects seem to work for the scenarios I have provided above. @gemmadallmandfe do you want to retest and ✅ ?

MylesJarvis commented 5 months ago

Summary of changes:

Request page Before

After

Cancelled by school, candidate then tries to cancel

Before

After

Candidate cancels a confirmed booking Before

After

Giving feedback on the service in general

Before

After

Giving feedback on a confirmed placement attendance

Before

After

School declines request, candidate then tries to withdraw

Before (NB the bug here on not showing the reasons for declining - written up a ticket for this as couldn't work out a fix in the code - https://trello.com/c/CHaqTvAQ)

After

github-actions[bot] commented 5 months ago

Review app deployed to https://get-school-experience-review-pr-3138.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-4.test.teacherservices.cloud