Add subjects to blacklist and remove from candidates dropdown menu

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Add subjects to blacklist and remove from candidates dropdown menu #3140

Closed MylesJarvis closed 2 months ago

MylesJarvis commented 2 months ago

Trello card

https://trello.com/c/dMfTRcRJ/

Context

Two subjects that we offer on school experience are not mirrored across the GIT ecosystem This is because the GIT website removed these subjects from their services to better mirror Find/Apply. In the spirit of ensuring consistency, it makes sense for us to remove these

Changes proposed in this pull request.

Adds physics with Maths and vocational health to gitis_subject_blacklist
Refactor Candidates::School#subjects method to exclude blacklisted subjects

Guidance to review

github-actions[bot] commented 2 months ago

Review app deployed to https://get-school-experience-review-pr-3140.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-8.test.teacherservices.cloud

MylesJarvis commented 2 months ago

From testing this appears to work perfectly, I've tested:

the subjects are removed from the candidate search
the subjects are removed from the subject list when a school is adding what subjects they offer

@ekumachidi I think you'll need to approve this and merge as it's my PR.