Improve DBS page (candidate flow) accessibility

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Improve DBS page (candidate flow) accessibility #3155

Closed MylesJarvis closed 5 months ago

MylesJarvis commented 5 months ago

Trello card

https://trello.com/c/zo7QPFde

Context

We've identified some issues with this page, such as a link needing context, and unnecessary quote marks.
This PR corrects these.

Changes proposed in this pull request

Before

After

Guidance to review

Go through a candidate request and check the page
Do you think we need to remove the remaining bold text? I'm not sure it's necessary as such.

gemmadallmandfe commented 5 months ago

Looks good @MylesJarvis

Would also suggest removing the first link to DBS - there are currently two links on the page to the same destination but with different link text, which is not good practice from an accessibility perspective

github-actions[bot] commented 5 months ago

Review app deployed to https://get-school-experience-review-pr-3155.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-9.test.teacherservices.cloud