Improve button grouping on candidate flow - Githubissues

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Improve button grouping on candidate flow #3158

Closed MylesJarvis closed 2 months ago

MylesJarvis commented 2 months ago

Trello card

https://trello.com/c/QHKZbml7

Context

We have some poorly (or not at all) grouped buttons/links in the service. This PR addresses one of the most commonly seen ones on the candidate flow, on profiles.

Changes proposed in this pull request

Before

After

Guidance to review

Does this look good to you?
Let's test with schools that are not onboarded and onboarded but switched off too
Not onboarded: https://get-school-experience-review-pr-3158.test.teacherservices.cloud/candidates/schools/137843
Onboarded but switched off: https://get-school-experience-review-pr-3158.test.teacherservices.cloud/candidates/schools/139823

github-actions[bot] commented 2 months ago

Review app deployed to https://get-school-experience-review-pr-3158.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-11.test.teacherservices.cloud