Fix placement_date_option.rb to handle nil bookings_subject - Githubissues

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Fix placement_date_option.rb to handle nil bookings_subject #3165

Closed ekumachidi closed 5 months ago

ekumachidi commented 5 months ago

Trello card

https://trello.com/c/NOHbwt7v

Context

We're seeing issues with a few schools being able to receive requests. This appears to be due to our removal of subjects physics with maths and vocational health.
We are also seeing issues with ordering of subjects in lists when they have fixed placement dates, these appear to be intrinsically linked
This PR seeks to push a fix for the ordering issue

Changes proposed in this pull request

Before - Holland Park with multiple dates added with all subjects ticked

After

Guidance to review

github-actions[bot] commented 5 months ago

Review app deployed to https://get-school-experience-review-pr-3165.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-9.test.teacherservices.cloud