Further improve button grouping

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Further improve button grouping #3178

Closed MylesJarvis closed 1 month ago

MylesJarvis commented 2 months ago

Trello card

https://trello.com/c/QHKZbml7

Context

We know that button grouping is not implemented as it should be based on the design system
This has been fixed in some areas in preious PRs
This PR covers the final set

Changes proposed in this pull request

Group button and link on the 'change school' dashboard
Group button and link on CSV export
Group buttons on our accept/reject request page

Guidance to review

For the accept/reject request page, go to this page whilst being logged in as Outwood Academy Acklam: https://get-school-experience-review-pr-3.test.teacherservices.cloud/schools/placement_requests/370

MylesJarvis commented 2 months ago

School switching page

Before

After

NB: Font size seems to have increased following grouping - worth looking into this. Previous font sizing also had incorrect alignment on mobile devices, so this increased font size appears to be correct behaviour.

MylesJarvis commented 2 months ago

Accept/reject request page

Before

After

Note: tried to make the 'return to requests' secondary button a link, but some initial issues with alignment of text against the other buttons. Propose handling that later.

MylesJarvis commented 2 months ago

CSV Export

Before

After

github-actions[bot] commented 1 month ago

Review app deployed to https://get-school-experience-review-pr-3178.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-3.test.teacherservices.cloud