search

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.
https://dfe-digital.github.io/schools-experience/
MIT License
9 stars 4 forks source link

Surface location validation #3198

Closed martyn-w closed 4 months ago

martyn-w commented 4 months ago

validate for a location or query small rubocop fixes on other files

Trello card

Surface a validation error

Context

The Schools Experience does not show an error if the location field is left blank when searching for a schools experience

This is a re-implementation of work originally done in PR https://github.com/DFE-Digital/schools-experience/pull/3159 - now using Rails validators and GOVUK frontend libraries

Changes proposed in this pull request

Validate for location

Guidance to review

github-actions[bot] commented 4 months ago

Review app deployed to https://get-school-experience-review-pr-3198.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-1.test.teacherservices.cloud