Remove all references to service updates - Githubissues

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.

https://dfe-digital.github.io/schools-experience/

MIT License

9 stars 4 forks source link

Remove all references to service updates #3208

Closed MylesJarvis closed 3 weeks ago

MylesJarvis commented 4 weeks ago

Trello card

https://trello.com/c/TnZSL915

Context

We no longer want to have service updates on the GSE service, as it's an outdated mechanism for telling users about changes and we have been sporadic in creating these updates. This PR removes the functionality completely.

Changes proposed in this pull request

Remove the service update references from any front end pages
remove service update values from any files that help produce the service update pages and listing/indexing on the backend
Remove the service update references from any tests
Prevent a cookie being placed in relation to service update
Remove the service update cookie from the cookie policy

Guidance to review

Review with whitespace removed on the diff. Use this link: https://github.com/DFE-Digital/schools-experience/pull/3208/files?diff=split&w=1

gemmadallmandfe commented 3 weeks ago

@MylesJarvis @martyn-w

Is it worth adding a wildcard redirect from /service_updates (and all sub-pages) for tidiness, to cover all the deleted pages?

Should probably go to /schools/dashboard?

MylesJarvis commented 3 weeks ago

This has in fact deployed - redirect is working @gemmadallmandfe

github-actions[bot] commented 3 weeks ago

Review app deployed to https://get-school-experience-review-pr-3208.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-1.test.teacherservices.cloud