search

DFE-Digital / schools-experience

The Department for Education's Get Schools Experience Service which allows you to find out more about teaching by visiting schools.
https://dfe-digital.github.io/schools-experience/
MIT License
9 stars 4 forks source link

Fixed rubocop factory class name #3314

Open spencerldixon opened 5 days ago

spencerldixon commented 5 days ago

Trello card

https://trello.com/c/vOignwZ1/7002-clear-up-linting-errors-on-get-school-experience

Context

A recent rubocop bump on Get school experience uncovered over 6,000 linting errors

An attempt to autocorrect these linting errors didn’t work as other tests then started to break

Instead the errors have been moved to .rubocop_todo.yml

Changes proposed in this pull request

Guidance to review

github-actions[bot] commented 5 days ago

Review app deployed to https://get-school-experience-review-pr-3314.test.teacherservices.cloud :white_check_mark: DfE sign in route obtained: https://get-school-experience-review-pr-4.test.teacherservices.cloud