Edit example link text for consistency

DFE-Digital / technical-guidance

Principles, standards and guidance for digital delivery teams

https://technical-guidance.education.gov.uk/

Other

22 stars 18 forks source link

Edit example link text for consistency #115

Closed RogerHowellDfE closed 2 years ago

RogerHowellDfE commented 2 years ago

The code block entry (line 59) and the example below it (line 62) have different link text. This PR remedies this.

Note that the edit could have gone either way, but I opted for Digital tools support to remove any potential ambiguity or correlation with the variable name digital_tools.

RogerHowellDfE commented 2 years ago

Thanks @saliceti !

It looks like the GitHub action / check failed, however (due to missing cloud foundry credentials) and it seems to be limited to just this PR given that other runs in the first few pages have completed successfully.

Given that the PR is merged in I'm guessing it's not something we're concerned about?

RogerHowellDfE commented 2 years ago

Great nudge in the right direction from @saliceti separately that it is likely due to the PR coming from a fork rather than a branch within this repo, therefore secrets defined within this repo will not be available in the GHA -- I had overlooked this part, thanks! 👍