search

DFHack / df-structures

Dwarf Fortress data structure descriptions
https://github.com/DFHack/dfhack
116 stars 81 forks source link

Announcement_infost flag indicates sparring; identify unit_action_data_attack flag #714

Closed Bumber64 closed 6 months ago

Bumber64 commented 8 months ago

The check is done around 0x1404A570B (win64 Steam v50.11) using unit_action_data_attack.flags & 0x4000 to set a variable that is later used to set the announcement_infost.flags bit.

It seems like the announcement_infost.flags bit signifies sparring rather than hostile combat, once again. (I'll update this in the GUI announcement functions, as I'm almost done with those.)

Might as well identify the other unit_action_data_attack.flags, if we have access to them.

ab9rf commented 8 months ago

this change requires coordination due to the use of hostile_combat in Gui.cpp

Bumber64 commented 8 months ago

this change requires coordination due to the use of hostile_combat in Gui.cpp

https://github.com/DFHack/dfhack/pull/4247