More hardening for gui/gm-editor against crashes

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it

Other

1.87k stars 475 forks source link

More hardening for gui/gm-editor against crashes #1517

Open warmist opened 4 years ago

warmist commented 4 years ago

This usually is not an issue but during DF version changes this might help prevent some crashes and find some issues with structures. Namely i have this in mind:

Some pointer value checks. Check if points to allocated memory
String/vector length checks. Maybe warn if it's a huge vector. Also could improve perf for huge vectors

BenLubar commented 4 years ago

I think misaligned strings are the main cause of problems. We should probably do something at the C++ level to mark invalid strings (check-structures-sanity has code to determine whether a string is valid)