DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.84k stars 462 forks source link

translation module translates some names as empty strings #1528

Closed BenLubar closed 4 years ago

BenLubar commented 4 years ago

Seen for some deities, only words[2] was set to a nonnegative value. DFHack renders this as an empty string. Not sure what the game does, but it definitely doesn't render it as empty (or if it does, that's a second bug.)

PatrikLundell commented 4 years ago

My first approach would be to find the hist fig in the exported Legends XML, as you've got the id in that info (and my guess would be that it would be called whatever that second word is/translates to, but a check ought to show that).

Edit: Yes, I found an FB name "the pulpy" (exported legends name), which matches the Legends Mode one, so DF handles it. It can be noted that the investigation also uncovering cases like "iru the last" (exported Legends XML), which is translated as simply "Iru". No cases of orphaned parts 3 or 4 were found in the save examined, though.