Scripts doc-build GitHub action is generating nested zips

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it

Other

1.86k stars 471 forks source link

Scripts doc-build GitHub action is generating nested zips #1536

Closed lethosor closed 4 years ago

lethosor commented 4 years ago

Downloading docs.zip under "Artifacts" at https://github.com/DFHack/scripts/runs/559867231 gives a docs.zip file containing another docs.zip file. We're probably performing an extra unneeded zip step somewhere, since both files have the name we want.

BenLubar commented 4 years ago

if it's anything like BuildMaster, artifacts are zips, so we shouldn't be generating a zip at all

lethosor commented 4 years ago

Forgot I fixed this in https://github.com/DFHack/scripts/commit/8618cd0b0a17935fe07f329b249726cda61f5bdf