search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.86k stars 465 forks source link

Windows: console closes DF when closed #1679

Closed lethosor closed 3 years ago

lethosor commented 3 years ago

A Discord user mentioned that closing the DFHack console on Windows will quit the game without saving. I'm fairly certain that this is not intentional (it doesn't match behavior on other platforms), and it may actually be a crash that is silenced by #1048. Opening an issue to track since I don't have a proper Windows dev environment to debug this.

quietust commented 3 years ago

DFHack explicitly disables the Close button on its Console window (using code that reportedly worked as far back as Windows 2000), and I've confirmed that that logic works correctly on both both Windows 10 build 19041 and Windows 8.1.

However, this method doesn't seem to prevent you from closing the window from the Preview window that appears when hovering over its taskbar icon, or from right-clicking the taskbar icon and choosing the "Close Window" option at the bottom.

The following StackOverflow post suggests that preventing this may be impossible: https://stackoverflow.com/questions/11959643/

lethosor commented 3 years ago

Good to know, thanks. UristMcRilo provided the following screenshot, which does appear to be what you're describing (that or the alt-tab screen):

image

Probably nothing we can do here, then.