search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.88k stars 476 forks source link

dig-now turns mudstone walls into rocksalt boulders #3286

Open Saint-Ajora opened 1 year ago

Saint-Ajora commented 1 year ago

When I use Dignow on mudstone I get rocksalt boulders.

GAMESAVE :: https://dffd.bay12games.com/file.php?id=16581

MOD LIST :: mods.zip

myk002 commented 1 year ago

could you zip up your entire save directory? we need the whole thing, not just world.sav

Saint-Ajora commented 1 year ago

My apologies. It should be the correct file now. I didn't have that particular save but it is one from about an hour prior.

myk002 commented 1 year ago

This is interesting. dig-now is behaving correctly, but the lower-level map analysis is returning the biome layer as a rock salt layer: image

I'm not sure what to make of this. I'll have to go deeper.

myk002 commented 1 year ago

interesting, your embark has both rock salt and mudstone layers: image

could there be a z-level offset that is being interpreted incorrectly?

myk002 commented 1 year ago

hrm, no, orthoclase, which is only present on elevation -8, was boulderized correctly image

myk002 commented 1 year ago

I see the issue a few layers down with sandstone being converted into limestone

myk002 commented 1 year ago

I haven't been able to reproduce the problem on another map, but I didn't have mudstone (or sandstone) specifically on that map. I might have to come back to this later. It's not obvious at all what is going on.

myk002 commented 1 year ago

this issue shows up in prospect as well, where it's miscounting layer materials

silverwing235 commented 1 year ago

@myk002 not sure if the phone's your editing method of choice, or whatever, but you introduced a typo in the PR title?

myk002 commented 1 year ago

@myk002 not sure if the phone's your editing method of choice, or whatever, but you introduced a typo in the PR title?

ha, thanks. fixed.