DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.86k stars 465 forks source link

Update open-legends to current version #3377

Open DragonEyeNinja opened 1 year ago

DragonEyeNinja commented 1 year ago

export-legends is currently ready to be released with v50.08-r2. In previous versions of the game, open-legends would allow the player to view and export the legends screen, with the downside of having to force a crash to prevent save corruption.

While open-legends is allowed in v50 of Dwarf Fortress, it is currently entirely nonfunctional, only opening a blank screen. Being able to export the legends history of a fortress without having to retire it to an entirely new folder would certainly be nice, though because that workaround exists, it doesn't have to be a priority.

lethosor commented 1 year ago

~This may have already been done in https://github.com/DFHack/scripts/pull/697 - can you try that version of the script?~ edit: see below

I'm not sure if you were referring to the exportlegends changes in that same PR.

myk002 commented 1 year ago

I didn't actually get open-legends working. The method we previously used is causing crashes, and I wasn't able to find a way around it. I updated the structure of the script, but it didn't result in a functional script.

I left the docs with the "unavailable" tag for open-legends

DragonEyeNinja commented 1 year ago

Ah, I see. I wasn't aware of this; I just saw "done" in the PR and assumed that it was finished and at least basically functional.