search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.87k stars 472 forks source link

ban-cooking: don't ban things whose only use is cooking #4162

Open myk002 opened 9 months ago

myk002 commented 9 months ago

like leeks

reported here: https://www.reddit.com/r/dwarffortress/comments/193z3gy/comment/khia5n7/?utm_source=share&utm_medium=web2x&context=3

myk002 commented 5 months ago

this also applies to seedwatch -- plants that you can buy seeds for but you can't get seeds from the plants should not be banned

e.g. rhubarb?

ab9rf commented 4 months ago

this also applies to seedwatch -- plants that you can buy seeds for but you can't get seeds from the plants should not be banned

e.g. rhubarb?

seedwatch should ban cooking the seed but not the plant in this case

ab9rf commented 4 months ago

I don't think this is ban-cooking. The original report said that "When I manually allow them for cooking a couple seconds afterwards they are forbidden again." The thing is, ban-cooking is a one-shot tool, which means for this behavior to arise ban-cooking would have to be running on repeat, which it definitely doesn't do by default.

I'm leaning far more toward seedwatch here, but the original reporter said that "[s]eedwatch wasn't enabled" so I'm not sure what to think here. I've requested a save for diagnostic purposes in the reddit thread; in the mean time I'll have to think about trying to replicate the scenario somehow.