search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.88k stars 477 forks source link

twaterlvl.lua obsolete #4327

Open Bumber64 opened 8 months ago

Bumber64 commented 8 months ago

The water level indicator can be toggled in vanilla since v50. Script can probably be deleted.

fix/dead-units.lua might be now (v50.11?), too, though there could be a use-case for running it manually.

lethosor commented 8 months ago

Can the water level be toggled programmatically or with a single keypress in v50? If not, I would keep the script.

Bumber64 commented 8 months ago

Can the water level be toggled programmatically or with a single keypress in v50? If not, I would keep the script.

The script is just df.global.d_init.flags1.SHOW_FLOW_AMOUNTS = not df.global.d_init.flags1.SHOW_FLOW_AMOUNTS.

Keybind is df.interface_key.D_TOGGLE_FLUID_NUMBERS.

myk002 commented 8 months ago

fix/dead-units.lua might be now (v50.11?), too, though there could be a use-case for running it manually.

fix/dead-units is still needed -- the "original" functionality of purging dead units from the list is partially covered by vanilla. However the vanilla functionality only kicks in after 3 years, so players may want to run fix/dead-units to cull the list. In addition, the recently added "--burrows" option fixes a current bug where deceased units are not removed from burrows and the counts the game displays for how many units are assigned to the burrow incorrectly increases over time. This option is run by default as a "bugfix' option in gui/control-panel.

Can the water level be toggled programmatically or with a single keypress in v50? If not, I would keep the script.

Yeah, it's just f now: image I think we can probably remove twaterlvl. if we need the convenience of a simple command, we can turn it into an API call