search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.84k stars 462 forks source link

remove empty `zone` plugin #4659

Closed ab9rf closed 4 weeks ago

ab9rf commented 1 month ago

has been code-free since 2022

quietust commented 1 month ago

This is about the C++ Zone plugin, whose entire contents were completely commented out in this commit:

commit 2fa4efbb8afc42a948e0535182e42500091b160f
Author: Myk Taylor <myk002@yahoo.com>
Date:   Sat Jul 15 14:31:43 2023 -0700

    initial implementation of pasture assignment screen
myk002 commented 1 month ago

yes, but the Lua module will not be available without a stub plugin to load it. We could move the logic to a script, which would reset any custom overlay settings people have set for these overlays, which may inconvenience some players but is overall not too terrible, but I also don't feel too much pressure to remove zone from the build since we're planning on re-populating its cpp logic anyway.