search

DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.84k stars 463 forks source link

`suspend` command is broken #4717

Closed chdoc closed 1 week ago

chdoc commented 2 weeks ago

I just realized that there is yet another tool that was interacting with suspendmanager: suspend

From the looks of it, the variant without arguments used suspend every single construction job there is. This would be easy to implement, even in Lua, and AFAIK is not currently doable by user-facing tools.

The --onlyblocking option is trickier, because it is a mode of operation that is not currently supported by suspendmanager. Is it really worthwhile to spend time to explicitly avoid preserving designations and the likes?

Does anyone object to dropping the --onlyblocking option? The fact that nobody has noticed until now, leads me to believe that this tool doesn't have a huge user base.

myk002 commented 2 weeks ago

I'm fine with making it simpler to maintain. Now that suspendmanager is so effective, the need for these lower level tools is much diminished