DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.84k stars 463 forks source link

Figure out how to not crash if a civalert is active when you retire #4730

Closed myk002 closed 1 week ago

myk002 commented 1 week ago

And then unretire the site

Ref: https://discord.com/channels/793331351645323264/807444467140788254/1252350146159575140 https://discord.com/channels/329272032778780672/1049402643342168114/1252349525822017536

myk002 commented 1 week ago

Might be fixed in DF; check with Putnam

ab9rf commented 1 week ago

also it's come to my attention that the circumstance that led to this was caused by doing disordered inserts into df vectors that were supposed to be sorted. i suspect this is not a high priority issue, and while we should investigate it this isn't a blocker by any means

quietust commented 1 week ago

From what I recall, performing a typical binary search algorithm on an unsorted list tends to result in "undefined behavior" and can potentially end up reading past the end or before the beginning of the list, so crashes wouldn't be unusual at all.

myk002 commented 1 week ago

ok, closing as unactionable