DFHack / stonesense

A retro isometric visualizer for Dwarf Fortress
https://github.com/DFHack/dfhack
Other
370 stars 54 forks source link

Several professions without match #94

Open jakke-korpelainen opened 1 year ago

jakke-korpelainen commented 1 year ago

DFHack version 50.05-alpha2 (release) on x86_64

Unable to match profession 'SLAVE' to anything in-game Unable to match profession 'PRISONER' to anything in-game Unable to match profession 'BARON_CONSORT' to anything in-game Unable to match profession 'COUNT_CONSORT' to anything in-game Unable to match profession 'DUKE_CONSORT' to anything in-game Unable to match profession 'SHOPKEEPER' to anything in-game Unable to match profession 'GUILDREP' to anything in-game Unable to match profession 'MERCHANTBARON' to anything in-game Unable to match profession 'MERCHANTPRINCE' to anything in-game Unable to match profession 'TAXCOLLECTOR' to anything in-game Unable to match profession 'ADVISOR' to anything in-game Unable to match profession 'ALCHEMIST' to anything in-game Unable to match profession 'DUNGEONMASTER' to anything in-game Unable to match profession 'EXECUTIONER' to anything in-game Unable to match profession 'OUTPOSTLIAISON' to anything in-game Unable to match profession 'ARCHITECT' to anything in-game

Was trying to see what crashed my stonesense, not sure if this should cause any issues though.

lethosor commented 1 year ago

Are you using any mods?

jakke-korpelainen commented 1 year ago

Shouldn't be anything else running at the moment in this world. The freeze occurs in stonesense when I go to a specific Z level so I think there is something breaking silently there. Just thought that these professions might be something that should be fixed as well since they're warnings or errors.

dejazzhands commented 1 year ago

can i be assigned to this issue? i'd like to contribute!

lethosor commented 1 year ago

Sure, there ya go. (It's not strictly required that you be assigned first, for the purposes of DFHack projects, but I suppose it's helpful for longer threads in particular.)

dejazzhands commented 1 year ago

i'm trying to narrow down the files that might cause this problem. i saw characterconfiguration.cpp is one of the many (presumably) that assigns professions. are there any other files you can think of?

jakke-korpelainen commented 1 year ago

i'm trying to narrow down the files that might cause this problem. i saw characterconfiguration.cpp is one of the many (presumably) that assigns professions. are there any other files you can think of?

I suspect the logging come from here: https://github.com/DFHack/stonesense/blob/cd387d9e4bc1a22c4cb61065f9eaef24ac8d2e5b/CreatureConfiguration.cpp#L49