search

DFKI-NI / mir_robot

ROS support for the MiR Robots. This is a community project to use the MiR Robots with ROS. It is not affiliated with Mobile Industrial Robots.
BSD 3-Clause "New" or "Revised" License
239 stars 157 forks source link

Remove unused EncoderTestEntry and PrecisionDockingStatus #97

Closed brean closed 2 years ago

brean commented 2 years ago

rosnodejs will not start because it will not try to generate js-files for them but relies on their import.

mintar commented 2 years ago

I'd prefer to keep these messages, because the current state of the package corresponds to the mirMsgs package on the real MiR software, and perhaps we'll need them later on. For example, SoundEvent is actually published by the MiR, just commented out at the moment.

The fact that these messages are not being built is a bug. I'm proposing a fix in #98, and I'd prefer to merge #98 instead of this PR. What do you think?

brean commented 2 years ago

Works for me, I just delete the files after checkout in my Dockerfile. Might also be worth a bug-report to rosnodejs to ignore files that are not in the CMakelist.txt

mintar commented 2 years ago

Works for me, I just delete the files after checkout in my Dockerfile.

Ok, I've merged #98. Now deleting the files shouldn't be necessary any more, right?

Might also be worth a bug-report to rosnodejs to ignore files that are not in the CMakelist.txt

Yes, that sounds like a good idea. It was a bug in mir_msgs, but probably also a bug in rosnodejs.

brean commented 2 years ago

yes, it is working now without my workaround (deleting files).