Clean up item_locations interface where only the items are required - Githubissues

DFKI-NI / mobipick_labs

Other

4 stars 1 forks source link

Clean up item_locations interface where only the items are required #43

Closed alexander-sung closed 8 months ago

alexander-sung commented 9 months ago

Another small refactoring pull request which aims at removing actual item locations from the interfaces of real demos where this information is neither given nor needed. Concept:

Retain item_locations only for simulation.
At interfaces where the relevant items must be provided, expect api_items: Iterable[Item].
When creating demos, only specify demo_items: List[Item] at script level. Their location information must come from other sources, e.g., symbolic fact generation.

If you encounter errors due to missing UP locations, please make sure to create them during environment setup. Previously, the Location.get() commands did it implicitly but as of now, https://github.com/DFKI-NI/mobipick_labs/blob/noetic/tables_demo_planning/src/tables_demo_planning/tables_demo_api.py#L46 is probably doing it for the three tables explicitly listed there.

alexander-sung commented 8 months ago

@mintar @sebastianstock This is the pull request I was speaking of. The UP objects for the Locations need to be created explicitly for all tables now because since this pull request they are not mentioned in the start script anymore - obviously they must be.

Still, another review is necessary to rate whether the "caching" mechanism is actually helpful.