fix boolean and integer conversion

DFKI-NI / rospy_message_converter

Converts between Python dictionaries and JSON to ROS messages.

BSD 3-Clause "New" or "Revised" License

226 stars 101 forks source link

fix boolean and integer conversion #24

Closed jabbenseth closed 4 years ago

jabbenseth commented 5 years ago

boolean and integer values were serialized as doubles (True or 1 to 1.0 and False or 0 to 0.0) which breaks parsing the generated dictionaries with the c++ yaml module..

mintar commented 5 years ago

Thanks for your contribution! I've tried to reproduce the faulty behaviour, but I couldn't. Could you add some test cases to test/*.py that fail before your fix and succeed afterwards?

mintar commented 5 years ago

@ros-pull-request-builder retest this please

jabbenseth commented 4 years ago

actually I cannot reproduce it either and given that I will close this PR for now