search

DFKI-NI / rospy_message_converter

Converts between Python dictionaries and JSON to ROS messages.
BSD 3-Clause "New" or "Revised" License
226 stars 101 forks source link

optionally ignore extra fields when deserializing #29

Closed jabbenseth closed 4 years ago

jabbenseth commented 4 years ago

closed one PR, opened another.

We often ran into troubles that we used the message converter to connect two systems with different "capabilities". If one non-ros System send a message which contained additional fields compared to "our" definition of the ros message, the message converter raises a ValueError. With the additional option strict_mode for converting json or dictionaries to ros messages extra fields can just be ignored.

Default behavior stays as before. The new feature needs to be explicitly enabled

jabbenseth commented 4 years ago

The pipeline fails are in indigo and lunar, how to deal with those? never mind

mintar commented 4 years ago

The pipeline fails are in indigo and lunar, how to deal with those?

Just rebase onto current master, I've removed indigo and lunar just now. The tests fail because those distros are EOL and have been removed from rosdep.

mintar commented 4 years ago

Thanks for the PR! Merged.