search

DFKI-NLP / thermostat

Collection of NLP model explanations and accompanying analysis tools
Apache License 2.0
145 stars 8 forks source link

Edit dependency to new scikit-learn nomenclature #18

Closed g8a9 closed 1 year ago

g8a9 commented 1 year ago

Hey, this PR will update the name of the scikit-learn package in the list of requirements, due to their new naming convention.

(this is breaking the pip install in ferret :) )

nfelnlp commented 1 year ago

Thanks a lot for pointing this out, Giuseppe! :slightly_smiling_face: I'm planning to do some maintenance and push a new version in the near future, but this fix can already be merged now.

g8a9 commented 1 year ago

Just for completeness, I don't think this will fix the issue until a new thermostat version is deployed with the right scikit-learn name. That might potentially impact any package having thermostat as a dependency.

As of now, we updated ferret's README suggesting people try:

SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install ferret-xai